Generate a PyVista grid directly without meshio as intermediate step #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
keurfonluu
commented
Feb 28, 2025
src/skgmsh/__init__.py
Outdated
| element_types, element_tags, element_node_tags = gmsh.model.mesh.getElements() | ||
|
|
||
| # Points | ||
| assert (np.diff(node_tags) > 0).all() |
There was a problem hiding this comment.
Not sure if this is ever False. pygmsh is checking whether tags are sorted, so I left it.
keurfonluu
commented
Feb 28, 2025
src/skgmsh/__init__.py
Outdated
| cells = {} | ||
|
|
||
| for type_, tags, node_tags in zip(element_types, element_tags, element_node_tags): | ||
| assert (np.diff(tags) > 0).all() |
There was a problem hiding this comment.
Same here (seems to be always True).
for more information, see https://pre-commit.ci
…eurfonluu/scikit-gmsh into feature/generate-mesh-function
tkoyama010
approved these changes
Mar 3, 2025
|
Congrats on merging your first pull request! We here at behaviorbot are proud of you! |
|
@all-contributors please add @keurfonluu for code |
|
I've put up a pull request to add @keurfonluu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Conversion from gmsh API to PyVista grid is straightforward. There is no need to use
meshio.Meshas intermediate mesh. Bonus,pygmshis no longer required as dependency.Details
generate_mesh.