Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct detector shape of returned EBSD signal from downsample() #674

Merged
merged 10 commits into from
May 30, 2024

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented May 28, 2024

Description of the change

In preparation for a workshop during the two-days Nordic Nanolab User Meeting (NNUM) in Oslo next week, I encountered some bugs and things which need updating.

Fixes #668.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

@hakonanes hakonanes added the bug Something isn't working label May 28, 2024
@hakonanes hakonanes added this to the v0.10.0 milestone May 28, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hakonanes hakonanes merged commit ec872cf into pyxem:develop May 30, 2024
11 of 12 checks passed
@hakonanes hakonanes deleted the bug-fixes-0.9.1 branch May 30, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect detector shape for downsampled signal
1 participant