Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 and 3.9 compatibility #689

Merged
merged 12 commits into from
Oct 5, 2024

Conversation

hakonanes
Copy link
Member

Description of the change

Core dependency orix dropped Python 3.8 and 3.9 compatibility in v0.13.1, so it's fine for us to do the same.

This also means we can use types like list, tuple, dict etc. for type hints and replace Union[X, Y] with X | Y and Optional[int] with int | None etc. Makes reading and writing types much easier.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to kikuchipy/__init__.py and .zenodo.json.

Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
@hakonanes hakonanes added the maintenance This relates to package maintenance label Oct 2, 2024
@hakonanes hakonanes added this to the v0.11.0 milestone Oct 2, 2024
@hakonanes hakonanes merged commit a016c0a into pyxem:develop Oct 5, 2024
10 checks passed
@hakonanes hakonanes deleted the remove-38-39-compat branch October 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant