Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require sample identifiers to start with 5 alphanumeric characters #178

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Require sample identifiers to start with 5 alphanumeric characters #178

merged 3 commits into from
Jul 11, 2024

Conversation

KochTobi
Copy link
Member

No description provided.

@KochTobi KochTobi requested a review from a team as a code owner July 10, 2024 09:36
@github-actions github-actions bot added the fix label Jul 10, 2024
@KochTobi KochTobi requested review from sven1103 and removed request for sven1103 July 10, 2024 09:43
sven1103
sven1103 requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor requests, but I think they are important for the readability of the source code.

@KochTobi KochTobi requested a review from sven1103 July 11, 2024 10:55
@KochTobi KochTobi mentioned this pull request Jul 11, 2024
Merged
sven1103
sven1103 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@sven1103 sven1103 merged commit 39fd2c8 into main Jul 11, 2024
7 checks passed
@sven1103 sven1103 deleted the fix/restrict-sample-ids branch July 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1103 sven1103 sven1103 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KochTobi @sven1103