WebAPI: optionally include trackers list in torrent info response #22128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
reviewed
Jan 10, 2025
These aren't real trackers. Does it make sense in the output of this API endpoint? |
|
Not that I can think of. Only the real trackers are useful. Ok to remove then? 👍 |
Chocobo1
reviewed
Jan 11, 2025
This was referenced Jan 12, 2025
Chocobo1
reviewed
Jan 13, 2025
Chocobo1
approved these changes
Jan 13, 2025
glassez
approved these changes
Jan 14, 2025
|
@zze0s |
|
@zze0s thanks for the contribution! Tremendously useful to avoid fetching all trackers by every torrent hash 👌👌 |
Chocobo1
added a commit
that referenced
this pull request
Jan 24, 2025
This is another optimization for torrent management on large scale instances with the goal to minimize the amount of required API calls. Ref #22128. This new function and endpoint torrents/setTags does an upsert to replace the torrent tags and handles the removal and add internally, instead of doing multiple calls to add and remove tags on torrents from the client. PR #22156. --------- Co-authored-by: Chocobo1 <[email protected]> Co-authored-by: Vladimir Golovnev <[email protected]>
|
@CarlosLanderas ❤️ once this and #22156 lands in new versions and tools/libraries are updated it will make a huge difference for big instances! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter
includeTrackersto the Torrent info endpoint/torrents/infoto include the trackers list of each torrent in the response under the keytrackers.Why?
Me and a lot of other users runs anything between 1-40k torrents in a single instance and we rely on various tools to do things like tag by different tracker states.
To get the trackers we have to first get the list of torrents and then loop through that to get the trackers per torrent. With 10k torrents that's 10000+1 requests towards qBitorrent. It does handle it fairly well but it feels a bit wrong to spam it like that.
With this change we'll be able to get all that info in a single call (or few calls with pagination). It will most likely reduce the overall load quite a bit.
About the code
This is my first time touching c++ and making any changes to this codebase but I read the contributing guidelines etc so it should be to spec.
Not sure if
KEY_PROP_TRACKERSis the correct one to set or if it should beTORRENT_something instead.I just copied the
privatebool param so it behaves the same but it could potentially be changed toincludes=trackers,otherwhich takes a comma separated string of other things that could be of interest to include.The trackers logic is just a copy paste from the getTrackers endpoint. Not sure if
getStickyTrackers()should be included or not.I tested it locally and it works as expected with and without the new
includeTrackersquery param.