Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify router #125

Merged
merged 2 commits into from
Jan 27, 2024
Merged

simplify router #125

merged 2 commits into from
Jan 27, 2024

Conversation

qicosmos
Copy link
Owner

@qicosmos qicosmos commented Jan 27, 2024

#119

improve code

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0445168) 52.03% compared to head (7b7714c) 51.88%.

Files Patch % Lines
include/rest_rpc/router.h 57.14% 9 Missing ⚠️
examples/server/main.cpp 0.00% 6 Missing ⚠️
examples/client/main.cpp 0.00% 4 Missing ⚠️
include/rest_rpc/connection.h 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   52.03%   51.88%   -0.16%     
==========================================
  Files         166      166              
  Lines        7821     7812       -9     
==========================================
- Hits         4070     4053      -17     
- Misses       3751     3759       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Code Coverage Report
for detail, goto summary download Artifacts

Filename                    Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client_util.hpp                     3                 1    66.67%          19                 8    57.89%           2                 1    50.00%
codec.h                             4                 0   100.00%          24                 2    91.67%           0                 0         -
connection.h                       36                 4    88.89%         347                88    74.64%          68                34    50.00%
io_service_pool.h                   5                 0   100.00%          32                 1    96.88%          12                 1    91.67%
md5.hpp                            19                 2    89.47%         127                 8    93.70%          24                 0   100.00%
nonstd_any.hpp                     20                 5    75.00%          49                12    75.51%           8                 4    50.00%
router.h                           15                 2    86.67%         119                36    69.75%          10                 6    40.00%
rpc_client.hpp                     72                12    83.33%         657               152    76.86%         132                62    53.03%
rpc_server.h                       26                 3    88.46%         191                20    89.53%          40                 9    77.50%
string_view.hpp                    23                10    56.52%          72                35    51.39%          22                14    36.36%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             223                39    82.51%        1637               362    77.89%         318               131    58.81%

Copy link

Code Coverage Report
for detail, goto summary download Artifacts

Filename                    Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client_util.hpp                     3                 1    66.67%          19                 8    57.89%           2                 1    50.00%
codec.h                             4                 0   100.00%          24                 2    91.67%           0                 0         -
connection.h                       36                 4    88.89%         347                93    73.20%          68                36    47.06%
io_service_pool.h                   5                 0   100.00%          32                 1    96.88%          12                 1    91.67%
md5.hpp                            19                 2    89.47%         127                 8    93.70%          24                 0   100.00%
nonstd_any.hpp                     20                 5    75.00%          49                12    75.51%           8                 4    50.00%
router.h                           15                 2    86.67%         119                36    69.75%          10                 6    40.00%
rpc_client.hpp                     72                12    83.33%         657               152    76.86%         132                62    53.03%
rpc_server.h                       26                 3    88.46%         191                20    89.53%          40                 9    77.50%
string_view.hpp                    23                10    56.52%          72                35    51.39%          22                14    36.36%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             223                39    82.51%        1637               367    77.58%         318               133    58.18%

@qicosmos qicosmos merged commit bd30ca1 into master Jan 27, 2024
25 checks passed
@qicosmos qicosmos deleted the simplify_code branch January 27, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants