Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Implement a validation method for the OrthologFileFmt #321

Open
Sann5 opened this issue Apr 18, 2024 · 5 comments
Open

MAINT: Implement a validation method for the OrthologFileFmt #321

Sann5 opened this issue Apr 18, 2024 · 5 comments
Assignees

Comments

@Sann5
Copy link
Contributor

Sann5 commented Apr 18, 2024

Improvement Description
Implement a validation method for the OrthologFileFmt format (defined in the genome_data module). This format defines a FileCollection in the SeedOrthologDirFmt format which is associated with the SampleData[BLAST6] semantic type. This semantic type is used in the eggnog-diamond-search action from q2-moshpit.

Current Behavior
No validation method implemented, i.e. no validation is taking place.

Proposed Behavior
Validate these files which have a well-defined format (BLAST6).

@github-project-automation github-project-automation bot moved this to Backlog in 2024.10 🎃 Jun 6, 2024
@lizgehret lizgehret moved this from Backlog to In Analysis in 2024.10 🎃 Jun 6, 2024
@lizgehret
Copy link
Member

Hey @Sann5! We'd be happy to get this into the 2024.10 release - is this something that your team is planning on working on, or would you like us to implement?

@lizgehret lizgehret removed this from 2024.10 🎃 Jun 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in 2024.10 🎃 Jun 6, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in QIIME 2 - Triage 🚑 Jun 6, 2024
@lizgehret lizgehret moved this from Needs Triage to Awaiting Info in QIIME 2 - Triage 🚑 Jun 6, 2024
@Sann5
Copy link
Contributor Author

Sann5 commented Jun 7, 2024

Hey @lizgehret. It would be great if you could implement this 👍🏼. We were not planning on doing it anytime soon.

@lizgehret
Copy link
Member

Hey @misialq @VinzentRisch, figured I'd tag both of you for more visibility - but I'm just picking this one up and wanted to make sure I understand what the expected validation behavior should be. So for each file in the SeedOrthologDirFmt (i.e. each OrthologFileFmt), we want to validate that they contain the same structure as BLAST6Format files?

@misialq
Copy link
Collaborator

misialq commented Jan 14, 2025

Hey @lizgehret, yes, that's the idea! Although, there were one or two minor differences between the BLAST6 format and what EggNOG produces (that's where we use this format) so it would be worth checking. I don't remember exactly from the top of my head but I think one thing was about some additional comment on top of the file. Another one may have been about some columns not being present in one or the other of those formats. Let me know if you need more help in figuring those out!

@lizgehret
Copy link
Member

Okay got it, thanks @misialq! Will do some more poking around and let you know if I have any questions 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants