-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Implement a validation method for the OrthologFileFmt
#321
Comments
Hey @Sann5! We'd be happy to get this into the 2024.10 release - is this something that your team is planning on working on, or would you like us to implement? |
Hey @lizgehret. It would be great if you could implement this 👍🏼. We were not planning on doing it anytime soon. |
Hey @misialq @VinzentRisch, figured I'd tag both of you for more visibility - but I'm just picking this one up and wanted to make sure I understand what the expected validation behavior should be. So for each file in the |
Hey @lizgehret, yes, that's the idea! Although, there were one or two minor differences between the BLAST6 format and what EggNOG produces (that's where we use this format) so it would be worth checking. I don't remember exactly from the top of my head but I think one thing was about some additional comment on top of the file. Another one may have been about some columns not being present in one or the other of those formats. Let me know if you need more help in figuring those out! |
Okay got it, thanks @misialq! Will do some more poking around and let you know if I have any questions 🙂 |
Improvement Description
Implement a validation method for the
OrthologFileFmt
format (defined in thegenome_data
module). This format defines aFileCollection
in theSeedOrthologDirFmt
format which is associated with theSampleData[BLAST6]
semantic type. This semantic type is used in theeggnog-diamond-search
action fromq2-moshpit
.Current Behavior
No validation method implemented, i.e. no validation is taking place.
Proposed Behavior
Validate these files which have a well-defined format (BLAST6).
The text was updated successfully, but these errors were encountered: