[WIP] Experiment serialization and reconstruction #1423
+303
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added load method to `BaseExperiment` Added backend initialization to the experiment if available. `from_config` now also loads analysis if available.
ItamarGoldman
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will able the user to save and load experiment object to the result_db. This issue was discussed in #1392
Details and comments
Tasks to complete this PR:
make save experiment flag to save experiment config to the result_db
Add serialization of both Experiment obj, Analysis obj and figure related obj (for plotter, drawer and figure options)
Use the provider to add the correct backend to the experiment object.
Make a utility function to load experiment and experiment data simultaneously.
Add tests for simple experiment loading and saving
Add tests for composite experiments, e.g. flat, nesting etc..
This feature was requested by the experimentalists.
PR checklist (delete when all criteria are met)
CONTRIBUTING.md.renoif this change needs to be documented in the release notes.