Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

升级相关版本依赖 #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

升级相关版本依赖 #116

wants to merge 1 commit into from

Conversation

gundamff
Copy link
Contributor

No description provided.

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...cache-serializer-kryo/src/main/java/com/jarvis/cache/serializer/kryo/DefaultKryoContext.java
Kryo kryo = new Kryo();
registrations.forEach(reg -> reg.register(kryo));
return kryo;
}).softReferences().build();
}).softReferences().build();*/
//FIXME 32够不够
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量设计成可配置的

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...ipt/autoload-cache-script-springel/src/main/java/com/jarvis/cache/script/SpringELParser.java
@@ -17,7 +16,6 @@
*
*
*/
@Slf4j
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不能删除

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...ipt/autoload-cache-script-springel/src/main/java/com/jarvis/cache/script/SpringELParser.java
@@ -43,7 +41,7 @@ public class SpringELParser extends AbstractScriptParser {
hash = CacheUtil.class.getDeclaredMethod("getUniqueHashStr", new Class[]{Object.class});
empty = CacheUtil.class.getDeclaredMethod("isEmpty", new Class[]{Object.class});
} catch (NoSuchMethodException e) {
log
e.printStackTrace();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 log 输出

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...ipt/autoload-cache-script-springel/src/main/java/com/jarvis/cache/script/SpringELParser.java
@@ -43,7 +41,7 @@ public class SpringELParser extends AbstractScriptParser {
hash = CacheUtil.class.getDeclaredMethod("getUniqueHashStr", new Class[]{Object.class});
empty = CacheUtil.class.getDeclaredMethod("isEmpty", new Class[]{Object.class});
} catch (NoSuchMethodException e) {
log
e.printStackTrace();
} catch (SecurityException e) {
e.printStackTrace();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 log 输出

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...ipt/autoload-cache-script-springel/src/main/java/com/jarvis/cache/script/SpringELParser.java
@@ -43,7 +41,7 @@ public class SpringELParser extends AbstractScriptParser {
hash = CacheUtil.class.getDeclaredMethod("getUniqueHashStr", new Class[]{Object.class});
empty = CacheUtil.class.getDeclaredMethod("isEmpty", new Class[]{Object.class});
} catch (NoSuchMethodException e) {
log
e.printStackTrace();
} catch (SecurityException e) {
e.printStackTrace();
} catch (Exception e) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用log 输出

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...che-lock/autoload-cache-lock-jedis/src/main/java/com/jarvis/cache/lock/ShardedJedisLock.java
}

@Override
protected boolean setnx(String key, String val, int expire) {
ShardedJedis shardedJedis = null;
/*ShardedJedis shardedJedis = null;
try {
shardedJedis = shardedJedisPool.getResource();
Jedis jedis = shardedJedis.getShard(key);
return OK.equalsIgnoreCase(jedis.set(key, val, SetParams.setParams().nx().ex(expire)));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删除这些代码

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...che-lock/autoload-cache-lock-jedis/src/main/java/com/jarvis/cache/lock/ShardedJedisLock.java
}
}

@Override
protected void del(String key) {
ShardedJedis shardedJedis = null;
/*ShardedJedis shardedJedis = null;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删除这些代码

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...lock/autoload-cache-lock-jedis/src/src/main/java/com/jarvis/cache/lock/ShardedJedisLock.java

@Override
protected boolean setnx(String key, String val, int expire) {
/*ShardedJedis shardedJedis = null;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除这些代码。

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...lock/autoload-cache-lock-jedis/src/src/main/java/com/jarvis/cache/lock/ShardedJedisLock.java

@Override
protected void del(String key) {
/*ShardedJedis shardedJedis = null;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删除这些代码

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...oload-cache-manager-jedis/src/main/java/com/jarvis/cache/redis/ShardedJedisCacheManager.java
}

@Override
public void hset(byte[] key, byte[] field, byte[] value, int seconds) {
Jedis jedis = shardedJedis.getShard(key);
/*Jedis jedis = shardedJedis.getShard(key);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这代码没实现，那不就不工作了。

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...oload-cache-manager-jedis/src/main/java/com/jarvis/cache/redis/ShardedJedisCacheManager.java
}

@Override
public void mset(Collection<MSetParam> params) {
ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
/*ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这代码没实现，那不就不工作了。

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...oload-cache-manager-jedis/src/main/java/com/jarvis/cache/redis/ShardedJedisCacheManager.java
}

@Override
public Map<CacheKeyTO, CacheWrapper<Object>> mget(Type returnType, Set<CacheKeyTO> keys) throws Exception {
ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
/*ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这代码没实现，那不就不工作了。

qiujiayu
qiujiayu reviewed Jul 13, 2022
View reviewed changes
...oload-cache-manager-jedis/src/main/java/com/jarvis/cache/redis/ShardedJedisCacheManager.java
}

@Override
public void delete(Set<CacheKeyTO> keys) {
ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
/*ShardedJedisPipeline pipeline = new ShardedJedisPipeline();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这代码没实现，那不就不工作了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiujiayu qiujiayu qiujiayu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gundamff @qiujiayu