-
-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epomaker tide75 #23552
base: master
Are you sure you want to change the base?
Epomaker tide75 #23552
Conversation
Co-authored-by: jack <[email protected]>
@waffle87 Could you please help me merge this Pull Request? If you have any questions or need further information, please feel free to let me know. Thank you! |
This will only be for people like the collaborators like waffle87, or more so directors like tzarc. So only they have the power for merging PRs like this.
The easiest way you can make this PR go smoothly is if you follow the requested changes from any reviews made, and to not leave them unnoticed for months as some PRs in the past have done so. |
I sincerely appreciate your detailed feedback and guidance. I'm committed to meticulously addressing the reviewers' suggestions and actively monitoring the progress of this PR. With our collective effort, I'm confident we can swiftly merge this PR. |
@waffle87 |
"force_nkro": true, | ||
"pid": "0xE471", | ||
"suspend_wakeup_delay": 1000, | ||
"vid": "0x342D" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be Westberry's vendor ID. Do you have permission from them to use this VID+PID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have permission to use it. We applied to Westberry.
Converted to draft and marked with As per the PR Checklist: |
This PR is on hold until #24085 is rectified. |
As of August 26, 2024, As you've submitted a PR containing |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist