Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rk890 keyboard #24078

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add rk890 keyboard #24078

wants to merge 1 commit into from

Conversation

sdk66
Copy link

@sdk66 sdk66 commented Jul 8, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 8, 2024
@sdk66
Copy link
Author

sdk66 commented Jul 9, 2024

We currently have two firmware versions: one is the QMK wired firmware, and the other is our self-developed tri-mode firmware. We do not know how to develop a QMK tri-mode keyboard. This keyboard uses the QMK firmware for wired functionality and does not have wireless capabilities. The wireless functionality is provided by a separately developed firmware that is not based on QMK.

@tzarc
Copy link
Member

tzarc commented Jul 10, 2024

This PR is on hold until #24085 is rectified.

@tzarc tzarc marked this pull request as draft July 10, 2024 07:52
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap needs-wireless-code via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants