[OS Detection] Improve MacOS detection #24708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
Dec 12, 2024
| @@ -133,7 +133,7 @@ void process_wlength(const uint16_t w_length) { | |||
| } else if (setups_data.count == setups_data.cnt_ff) { | |||
| // Linux has 3 packets with 0xFF. | |||
| guessed = OS_LINUX; | |||
| } else if (setups_data.count == 5 && setups_data.last_wlength == 0xFF && setups_data.cnt_ff == 1 && setups_data.cnt_02 == 2) { | |||
| } else if (setups_data.count >= 5 && setups_data.last_wlength == 0xFF && setups_data.cnt_ff >= 1 && setups_data.cnt_02 >= 2) { | |||
There was a problem hiding this comment.
// Some collected sequences of wLength can be found in tests.
Any chance we can collect a sample of the "new" macos behaviour and update tests so they pass?
There was a problem hiding this comment.
added to comments and tests
tzarc
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix detection for macOS by making the detection more flexible.
Types of Changes
Issues Fixed or Closed by This PR
Checklist