[keyboard]add XVX M67 keyboard.

[jonylee1986]

add XVX M67 keyboard.

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[zvecr]

I think we are going to require the code for the "wireless" version for validation, before we can consider this PR.

[jonylee1986]

@zvecr hello！
We have a pure wired product, the product link has been updated, please let us know if it is feasible!

[zvecr]

Per #24085,

If QMK identifies any licensing violation, all current and future PRs from that manufacturer will be put on hold until sources are provided. QMK's license requires full disclosure of source code for any firmware which is based on QMK, includes any part of QMK, or derives from QMK in any way. This source code disclosure is not negotiable and is automatically agreed to by any designer when they choose to use QMK.

Nope, we are going to require the code for the "wireless" version for validation, before we can consider this PR.

[badmark]

Nope, we are going to require the code for the "wireless" version for validation, before we can consider this PR.

This is a wired only keyboard, what's the issue here?

[adophoxia]

Nope, we are going to require the code for the "wireless" version for validation, before we can consider this PR.

This is a wired only keyboard, what's the issue here?

The issue is that for certain manus' that make a wired and wireless variant of a board, if they wanted to have VIA compatibility for their wireless board and tout it so, but not submit the source code for it for petty reasons, they would bypass this via submitting source code for the wired variant, add the keymap/JSON for VIA, to where the wireless variant can piggyback off of the VID and/or PID for auto-detect with VIA.

This is how deceitful companies like CIDOO/Zuoyu, Epomaker, and the like do so for their boards since no matter what, their stock firmware always shows up as a GMMK Numpad in VIA until after a JSON is loaded.

So in this case, if the wireless variant of this xvx m67 does use QMK/VIA, they need to disclose the source code for all variants. In short, release for all, or not and continue this stupid workaround.

[badmark]

There is no wireless variant of this keyboard!

[fauxpark]

https://www.xvxchannel.com/en-au/collections/xvx-m67-jadestone/products/xvx-m67-jadestone-mechanical-keyboard-with-imd-tech-keycaps-interstellar-black
And you can see in the image above posted by zvecr, there is most definitely a wireless variant.

[zvecr]

Posting this as its likely they will try and remove the listing from the site

[badmark]

I have seen this, I am trying to help them do QMK the right way, this was their marketing department's mistake. If they correct this image, can they continue the PR process?

[daskygit]

I can buy a wireless XVX M67 from Amazon that advertises QMK/VIA support. What exactly is the mistake?

[tzarc]

Locked this issue as it’s devolving — there’s ample evidence and ample ambiguity to demand the wireless variant’s sources.

See license violations - PR considerations for QMK's stance on such things. All PRs for this vendor are now indefinitely on hold accordingly.

Will update the license violations page to reflect the outcome of this PR.