Feature/restructure project for python #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stand-by
force-pushed
the
feature/restructure-project-for-python
branch
from
7451077
to
b1ea886
Compare
stand-by
force-pushed
the
feature/restructure-project-for-python
branch
from
b1ea886
to
82e4007
Compare
jamesETsmith
requested changes
Jul 19, 2024
jamesETsmith
requested changes
Jul 21, 2024
There was a problem hiding this comment.
Looking good @stand-by, just one more thing in the Makefile and then I think we're good to go on this
jamesETsmith
requested changes
Jul 22, 2024
jamesETsmith
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to establish the structure and populate boilerplate. Things are probably going to evolve and change as we develop our codebase, but this should be a good starting point. With these changes everything runs fine and should not crash. pyproject.toml/setup.py situation needs some work for proper packaging so I'd prefer to arrange that into a separate task