Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qstring.cpp #114

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

SpaceAccordeonist
Copy link

Set blockSize type to qsizetype.

All variables in evaluation of this value are qsizetype. So it's not a good idea to make it int even if we know that its size is in certain range. Moreover, its size can differ on different platforms.

It can also lead to the problems with overflow a few lines below, where multiplication by 2 takes place.

Set blockSize type to qsizetype.

All variables in evaluation of this value are qsizetype. So it's not a good idea to make it int even if we know that its size is in certain range. Moreover, its size can differ on different platforms.
Copy link

cla-assistant bot commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 29, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant