Add DynamicalDecouplingTag to cirq-google #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
wcourtney,
vtomole,
verult and
a team
as code owners
NoureldinYosri
commented
Nov 5, 2024
eliottrosenberg
approved these changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6782 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 1083 1085 +2
Lines 93550 93592 +42
=======================================
+ Hits 91540 91583 +43
+ Misses 2010 2009 -1 ☔ View full report in Codecov by Sentry. |
pavoljuhas
requested changes
Nov 9, 2024
| class DynamicalDecouplingTag: | ||
| """A tag to indicate using DD to fill qubit time.""" | ||
|
|
||
| protocol: str = attrs.field() # Which DD protocol to use. |
There was a problem hiding this comment.
Nit: attrs.field() seems unnecessary. Also please describe in the docstring, e.g.,
Attributes:
protocol: The name of the decoupling protocol (eg 'X', 'XY4').
There was a problem hiding this comment.
Added the docstring
Nit: attrs.field() seems unnecessary. Also please describe in the docstring, e.g.,
this is requried by attrs for the validation code
pavoljuhas
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds the new proto message and its serialization to/from dataclass