Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using the black formatter #835

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

mpharrigan
Copy link
Collaborator

  • copy check/format-incremental from Cirq (one minor edit to remove an unnecessary exclude line)
  • copy black version pin from Cirq so our open-source dev environments are mildly in sync.

Instead of formatting everything all at once, I plan on just letting the formatting change slowly over time as PRs format only their changed files. cc @ncrubin @fdmalone @tanujkhattar

@fdmalone
Copy link
Collaborator

fdmalone commented Oct 16, 2023

Why not format everything in one go @mpharrigan? It seems like formatting incrementally will increase noise during review.

@fdmalone fdmalone self-requested a review October 19, 2023 17:34
@fdmalone
Copy link
Collaborator

cirq did this all in one go right, with some git-blame-ignore-revs?

@tanujkhattar
Copy link
Collaborator

cirq did this all in one go right, with some git-blame-ignore-revs?

Yes

@fdmalone
Copy link
Collaborator

With that being said, I'd rather switch to black in one way or another. Can follow up with a bulk reformat.

@fdmalone
Copy link
Collaborator

xref #835

@fdmalone fdmalone merged commit ad46270 into quantumlib:master Oct 19, 2023
11 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants