Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggestions from CommonTypos checker #650

Merged
merged 3 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/choose_hw.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ backends and do not involve sampling bitstrings (i.e. no measure gates).
For GPU-based simulations, you can either use qsim's native GPU backend
or the NVIDIA cuQuantum backend. While the native qsim GPU backend is performant
for extracting amplitudes of specific quantum states, it is not optimized for
sampling bitstrings, i.e. for simulating circuits that have measurement gates. For
sampling bitstrings, i.e., for simulating circuits that have measurement gates. For
that purpose, cuQuantum performs significantly better. cuQuantum is also needed
for multi-GPU support. More specifically, there are three options for GPU-based
simulations:
Expand Down Expand Up @@ -132,9 +132,9 @@ Alternatively, you can use your own hardware.
Note the [hardware requirements](https://docs.nvidia.com/cuda/cuquantum/getting_started.html#custatevec)
for NVIDIA's cuQuantum when picking a GPU; in particular, it must have
CUDA Compute Capability 7.0 or higher.
At the time of writing, the following compatable GPUs are available on GCP:
At the time of writing, the following compatible GPUs are available on GCP:
* [NVIDIA T4](https://www.techpowerup.com/gpu-specs/tesla-t4.c3316).
This is the least expensive compatable GPU on GCP.
This is the least expensive compatible GPU on GCP.
It has 16GB of memory and can therefore simulate up to 30 qubits.
It is not compatible with multi-GPU simulations.
* [NVIDIA V100](https://www.techpowerup.com/gpu-specs/tesla-v100-pcie-16-gb.c2957).
Expand Down
4 changes: 2 additions & 2 deletions docs/type_reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ they fulfill the same expectations.
| Bitstring | Alias for `uint64_t`. |
| Circuit | [`Circuit`](https://github.com/quantumlib/qsim/tree/master/lib/circuit.h) |
| Container (util.h) | A vector of strings, or `Op`'s output type. |
| Ctype | A complex type, e.g. `std::complex<float>`. |
| Ctype | A complex type, e.g., `std::complex<float>`. |
| For | `for` loop abstractions, see below. |
| ForArgs | Arguments for constructing `For` objects, see below. |
| FP (simulator_basic.h) | Same as `fp_type`. |
| fp_type | A floating-point type, i.e. `float` or `double`. |
| fp_type | A floating-point type, i.e., `float` or `double`. |
| Function (parfor.h) | Any function; args are specified with `Args`. |
| FuserT | [`BasicGateFuser`](https://github.com/quantumlib/qsim/tree/master/lib/fuser_basic.h) |
| Gate | [`Gate`](https://github.com/quantumlib/qsim/tree/master/lib/gate.h) |
Expand Down
2 changes: 1 addition & 1 deletion lib/fuser_basic.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class BasicGateFuser final : public Fuser<IO, Gate> {
* @param gfirst, glast The iterator range [gfirst, glast) to fuse gates
* (or pointers to gates) in. Gate times of the gates that act on the same
* qubits should be ordered. Gates that are out of time order should not
* cross the time boundaries set by `times_to_split_at` or by measurment
* cross the time boundaries set by `times_to_split_at` or by measurement
* gates.
* @param times_to_split_at Ordered list of time steps (boundaries) at which
* to separate fused gates. Each element of the output will contain gates
Expand Down
2 changes: 1 addition & 1 deletion lib/fuser_mqubit.h
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class MultiQubitGateFuser final : public Fuser<IO, Gate> {
* @param gfirst, glast The iterator range [gfirst, glast) to fuse gates
* (or pointers to gates) in. Gate times of the gates that act on the same
* qubits should be ordered. Gates that are out of time order should not
* cross the time boundaries set by `times_to_split_at` or by measurment
* cross the time boundaries set by `times_to_split_at` or by measurement
* gates.
* @param times_to_split_at Ordered list of time steps (boundaries) at which
* to separate fused gates. Each element of the output will contain gates
Expand Down
10 changes: 5 additions & 5 deletions qsimcirq/qsim_simulator.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,10 @@ def compute_amplitudes_sweep_iter(
bitstrings: The bitstrings whose amplitudes are desired, input as an
string array where each string is formed from measured qubit values
according to `qubit_order` from most to least significant qubit,
i.e. in big-endian ordering.
i.e., in big-endian ordering.
param_resolver: Parameters to run with the program.
qubit_order: Determines the canonical ordering of the qubits. This is
often used in specifying the initial state, i.e. the ordering of the
often used in specifying the initial state, i.e., the ordering of the
computational basis states.

Yields:
Expand Down Expand Up @@ -539,7 +539,7 @@ def simulate_sweep_iter(
program: The circuit to simulate.
params: Parameters to run with the program.
qubit_order: Determines the canonical ordering of the qubits. This is
often used in specifying the initial state, i.e. the ordering of the
often used in specifying the initial state, i.e., the ordering of the
computational basis states.
initial_state: The initial state for the simulation. This can either
be an integer representing a pure state (e.g. 11010) or a numpy
Expand Down Expand Up @@ -587,7 +587,7 @@ def simulate_expectation_values_sweep_iter(
observables: An observable or list of observables.
params: Parameters to run with the program.
qubit_order: Determines the canonical ordering of the qubits. This
is often used in specifying the initial state, i.e. the
is often used in specifying the initial state, i.e., the
ordering of the computational basis states.
initial_state: The initial state for the simulation. The form of
this state depends on the simulation implementation. See
Expand Down Expand Up @@ -706,7 +706,7 @@ def simulate_moment_expectation_values(
or observable list to calculate after ALL moments.
param_resolver: Parameters to run with the program.
qubit_order: Determines the canonical ordering of the qubits. This
is often used in specifying the initial state, i.e. the
is often used in specifying the initial state, i.e., the
ordering of the computational basis states.
initial_state: The initial state for the simulation. The form of
this state depends on the simulation implementation. See
Expand Down
Loading