Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt enabling of continuous testing to new DEV UI #732

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 13, 2023

Summary

Adapts enabling of continuous testing to new DEV UI added by quarkusio/quarkus#32491.
HtmlUnit doesn't handle Vaadin correctly (likely because of importmaps), I decided to use PlayWright as Phillip Krüger suggested that's what he eventually plans to use and Aleš Justin also experiments with it: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Testing.20in.20Dev.20UI

It turned out that HtmlUnit dependency brought in also Apache Commons utils we used in past, however I could easily avoid using this dependency (they are just simple util methods), so I dropped it from here. If anyone needs this in the future (e.g. in TS etc.), they should add it directly and only the dependency they really need.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/enable-continous-testing branch from 193eacb to 1108d2d Compare April 13, 2023 21:02
@michalvavrik michalvavrik requested a review from mjurc April 13, 2023 21:06
@michalvavrik michalvavrik force-pushed the feature/enable-continous-testing branch 2 times, most recently from baf4e80 to 4f3be14 Compare April 13, 2023 21:43
@michalvavrik
Copy link
Member Author

The failure is unrelated, it is the same thing as in the TS quarkus-qe/quarkus-test-suite#1148

@michalvavrik michalvavrik force-pushed the feature/enable-continous-testing branch from 4f3be14 to 509738a Compare April 14, 2023 11:10
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@mjurc mjurc merged commit 9d3a1ed into quarkus-qe:main Apr 14, 2023
@michalvavrik michalvavrik deleted the feature/enable-continous-testing branch April 14, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants