Adding test coverage to support encrypted PEM Keys #2320
+204
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarranzan
changed the title
jcarranzan
requested review from
michalvavrik and
fedinskiy
and removed request for
michalvavrik
fedinskiy
requested changes
Feb 27, 2025
security/https/src/test/java/io/quarkus/ts/security/https/secured/HttpsEncryptedPemIT.java
Show resolved
Hide resolved
...ps/src/test/java/io/quarkus/ts/security/https/secured/TlsRegistryCertificateReloadingIT.java
Outdated
Show resolved
Hide resolved
...ps/src/test/java/io/quarkus/ts/security/https/secured/TlsRegistryCertificateReloadingIT.java
Show resolved
Hide resolved
...rity/https/src/test/java/io/quarkus/ts/security/https/secured/TlsRegistryDecryptedKeyIT.java
Outdated
Show resolved
Hide resolved
security/https/src/main/java/io/quarkus/ts/security/https/TlsRegistryResource.java
Outdated
Show resolved
Hide resolved
Added in the summary, thanks. |
jcarranzan
force-pushed
the
support-encypted-pkcs#8
branch
2 times, most recently
from
68dbb91 to
48377ee
Compare
jcarranzan
force-pushed
the
support-encypted-pkcs#8
branch
from
ab26ea5 to
e777b12
Compare
fedinskiy
reviewed
Feb 27, 2025
There was a problem hiding this comment.
- Plans say "gRPC communication with encrypted Pem, verify you can use gRPC client to communicate with Quarkus gRPC server (running on the same server, not the separate one) that uses encrypted PEM file.", but I do not see nay GRPC tests here
- Did you check this on FIPS?
security/https/src/main/java/io/quarkus/ts/security/https/TlsRegistryResource.java
Show resolved
Hide resolved
jcarranzan
force-pushed
the
support-encypted-pkcs#8
branch
from
08b3446 to
ca97a83
Compare
These tests will be added: - Https communication using encrypted Pem, ensure you can communicate with Quarkus REST endpoint using HTTPS (no client-side authentication). - Certificate reloading, validate with newly generated certificate, it works for encrypted PEMs as well . - Injecting TLS registry configuration and can see the private key decrypted (so you can see keystore and check some x509 attributes). - FIPS compatibility, it works under FIPS enable environment.
jcarranzan
force-pushed
the
support-encypted-pkcs#8
branch
from
cc48b66 to
884c896
Compare
|
|
@fedinskiy, unfortunately, I am currently investigating some issues on FIPS with these tests. Maybe the TF might need some changes, but I need to verify that before reaching a conclusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These tests will be added to cover quarkusio/quarkus#44549
Jira issue: QUARKUS-5666
TP: TP-QUARKUS-5666
Also we did some TF support --> 1507
Please select the relevant options.
run testsphrase in comment)Checklist: