Display current args at edit prompt #37968

MaciejDromin · 2024-01-01T17:47:52Z

It fixes #37921 - point 3.
At the edit prompt it shows now current command line arguments, as shown in the screenshot below.

gsmet · 2024-01-03T18:39:33Z

@maxandersen could you test that one?

maxandersen · 2024-01-17T08:59:06Z

I tried this and it is better but still broken.

tried capture it in this recording:

2024-01-17_09-57-17.mp4

editing shows the current arg line correctly, but when I press enter it still shows "current arg: >" making me believe it is still asking for input.

But it is actually in devmode input mode as shorthand keys like d for debug etc works.

maxandersen · 2024-01-17T09:11:03Z

core/deployment/src/main/java/io/quarkus/deployment/console/ConsoleStateManager.java

@@ -70,7 +70,13 @@ public void accept(int[] ints) {
                    Holder command = commands.get(key);
                    if (command != null) {
                        if (command.consoleCommand.getReadLineHandler() != null) {
-                            QuarkusConsole.INSTANCE.doReadLine();
+                            if (key == 'e') {
+                                QuarkusConsole.INSTANCE.doReadLineWithPrompt("Current args: "


what do you think about just having it be:

"state list">

instead of:

Current args: "state list">

just to save some characters in width?

otherwise maybe split over two lines and not use current as you can't "escape" to reuse it?

Enter new arguments (was "state list"): >

Prompt changed

maxandersen

good changes but behavior still broken after pressing enter.

MaciejDromin · 2024-01-19T18:54:39Z

I tried this and it is better but still broken.
editing shows the current arg line correctly, but when I press enter it still shows "current arg: >" making me believe it is still asking for input.

But it is actually in devmode input mode as shorthand keys like d for debug etc works.

I think this might be some weird issue with different terminals, that's why I wasn't encountering this issue from your original issue:

Sometimes characters are not even shown when typing.

I am not seeing anything like this - maybe it is something related to Your terminal or OS? I checked this both in ZSH and Bash and it is fine, check the recording below:

q-issue.mp4

MaciejDromin · 2024-01-27T14:42:45Z

Hey @maxandersen! Have you maybe had a chance to look at the video I posted? I'm checking on the status of this PR.

maxandersen · 2024-01-27T14:43:56Z

Sorry. Missed the update. I'll check when back at my laptop.

MaciejDromin · 2024-02-08T19:08:38Z

Hey @maxandersen, I'm checking on the status, have You seen the update?

gsmet · 2024-06-07T15:47:15Z

@maxandersen I think we should merge this as it's better than what we had, even if it didn't fix the whole issue for you (apparently, it works for the OP so it might be environment-dependent).

WDYT?

maxandersen · 2024-06-10T11:50:50Z

you are probably right - let me try again.

MaciejDromin · 2024-07-08T10:13:41Z

Just wanted to let you know, that if there are still some issues with this PR which I will be able to reproduce, then I will be happy to fix them

maxandersen · 2024-07-16T12:09:02Z

i've tried to build this pr but keeps having weird issues building.

recent one is:

ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.9.22:test-compile (test-compile) on project arc-tests: Compilation failure: Compilation failure:
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/InterceptableSuspendMethodTest.kt:[3,23] Unresolved reference: Arc
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/InterceptableSuspendMethodTest.kt:[24,23] Unresolved reference: Arc
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/KotlinInterceptorTest.kt:[3,23] Unresolved reference: Arc
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/KotlinInterceptorTest.kt:[24,25] Unresolved reference: Arc
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/NotInterceptedSuspendMethodTest.kt:[3,23] Unresolved reference: Arc
[ERROR] /Users/manderse/code/quarkusio/quarkus/independent-projects/arc/tests/src/test/kotlin/io/quarkus/arc/test/interceptors/NotInterceptedSuspendMethodTest.kt:[18,23] Unresolved reference: Arc
[ERROR] -> [Help 1]
[ERROR

don't think its this pr fault but just t ogive context why didn'tconfirm the pr yet.

maxandersen · 2024-07-16T15:20:44Z

okey so I managed to build this when disabling cache (-Dno-build-cache=false) but i still see the issue of the line staying around.
It works just fine when I use quarkus 3.12.

so something in this PR or branch is triggering bad behaviour.

I tried using iterm2 and terminal - same result. works in 3.12 but with this PR it becomes broken.

maxandersen · 2024-07-16T15:22:27Z

also tried plain bash (so none of my zsh customization should influence it). same problem. the prompt keeps "hanging" and even though I can do things like 's' for restart or 'w' for open browser - the terminal is not showing I can do that.

Signed-off-by: Maciej Lisowski <[email protected]>

MaciejDromin · 2024-07-24T09:18:59Z

I have just retested this, and for me still works as it is supposed to even on the different OS.
But let's start from the beginning. First I rebased my changed on the top of main to have the latest and greatest and it went without any issues.
Next I build the project executing ./mvnw -Dquickly
Moving on to testing, I have created a new project by executing quarkus create app -x picocli whoops and updating the pom with following values:

<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
<quarkus.platform.version>999-SNAPSHOT</quarkus.platform.version>
<quarkus-plugin.version>999-SNAPSHOT</quarkus-plugin.version>

And now, using the just build CLI jar, I run this project in two different terminals (emulated by Intellij and system) and here are the results:

2024-07-24.11-16-38.mp4

@gsmet @maxandersen I'm not sure why it is happening to You, but like I said, I had no issues with building and running this change, and I tested this on different OS and shells. Maybe there are some steps that You do differently?

cescoffier · 2024-11-10T17:02:54Z

@maxandersen What should we do about this one?

cescoffier · 2024-12-09T07:46:15Z

@maxandersen What should we do about this one?

maxandersen · 2024-12-12T15:50:24Z

@MaciejDromin sorry for dropping ball on this one - it still fails for me so not sure how to fix it :/ maybe a shared screen/debug session would help? (sometime in the new year)

MaciejDromin · 2024-12-13T12:52:05Z

@maxandersen Sure, sounds good. Maybe together we will be able to figure out what is happening :D
I don't have any plans yet for January so I'm up for any date, maybe except of 6th

cescoffier · 2025-01-06T08:51:54Z

@maxandersen sounds like you will be able to debug it :-)

quarkus-bot bot added the area/core label Jan 1, 2024

MaciejDromin mentioned this pull request Jan 1, 2024

quarkus dev broken for command mode arguments #37921

Closed

MaciejDromin force-pushed the #37921-edit-args branch from 5731a4a to 0e614ed Compare January 4, 2024 11:12

MaciejDromin force-pushed the #37921-edit-args branch from 0e614ed to 2b574c6 Compare January 11, 2024 11:58

maxandersen reviewed Jan 17, 2024

View reviewed changes

maxandersen requested changes Jan 17, 2024

View reviewed changes

MaciejDromin force-pushed the #37921-edit-args branch from 2b574c6 to 72d761a Compare January 19, 2024 18:44

MaciejDromin added 2 commits July 24, 2024 09:45

Display current args at edit prompt

525b1d8

change prompt message

924ae7f

Signed-off-by: Maciej Lisowski <[email protected]>

MaciejDromin force-pushed the #37921-edit-args branch from 72d761a to 924ae7f Compare July 24, 2024 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display current args at edit prompt #37968

Display current args at edit prompt #37968

MaciejDromin commented Jan 1, 2024

gsmet commented Jan 3, 2024

maxandersen commented Jan 17, 2024

maxandersen Jan 17, 2024 •

edited

Loading

MaciejDromin Jan 19, 2024

maxandersen left a comment

MaciejDromin commented Jan 19, 2024

MaciejDromin commented Jan 27, 2024

maxandersen commented Jan 27, 2024

MaciejDromin commented Feb 8, 2024

gsmet commented Jun 7, 2024

maxandersen commented Jun 10, 2024

MaciejDromin commented Jul 8, 2024

maxandersen commented Jul 16, 2024

maxandersen commented Jul 16, 2024

maxandersen commented Jul 16, 2024

MaciejDromin commented Jul 24, 2024

cescoffier commented Nov 10, 2024

cescoffier commented Dec 9, 2024

maxandersen commented Dec 12, 2024

MaciejDromin commented Dec 13, 2024

cescoffier commented Jan 6, 2025

Display current args at edit prompt #37968

Are you sure you want to change the base?

Display current args at edit prompt #37968

Conversation

MaciejDromin commented Jan 1, 2024

gsmet commented Jan 3, 2024

maxandersen commented Jan 17, 2024

maxandersen Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

MaciejDromin Jan 19, 2024

Choose a reason for hiding this comment

maxandersen left a comment

Choose a reason for hiding this comment

MaciejDromin commented Jan 19, 2024

MaciejDromin commented Jan 27, 2024

maxandersen commented Jan 27, 2024

MaciejDromin commented Feb 8, 2024

gsmet commented Jun 7, 2024

maxandersen commented Jun 10, 2024

MaciejDromin commented Jul 8, 2024

maxandersen commented Jul 16, 2024

maxandersen commented Jul 16, 2024

maxandersen commented Jul 16, 2024

MaciejDromin commented Jul 24, 2024

cescoffier commented Nov 10, 2024

cescoffier commented Dec 9, 2024

maxandersen commented Dec 12, 2024

MaciejDromin commented Dec 13, 2024

cescoffier commented Jan 6, 2025

maxandersen Jan 17, 2024 •

edited

Loading