Speedup monomorphic switch type #38191
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geoand let me put it in draft, this is mostly to experiment, if you wanna give it a shot |
franz1981
force-pushed
the
main_switch_table
branch
from
37b13a8 to
72d7483
Compare
geoand
reviewed
Jan 15, 2024
geoand
reviewed
Jan 15, 2024
.../java/io/quarkus/resteasy/reactive/server/runtime/QuarkusResteasyReactiveRequestContext.java
Show resolved
Hide resolved
gastaldi
reviewed
Jan 15, 2024
.../java/io/quarkus/resteasy/reactive/server/runtime/QuarkusResteasyReactiveRequestContext.java
Show resolved
Hide resolved
franz1981
force-pushed
the
main_switch_table
branch
from
94a72eb to
3a518fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could hit a performance issue (see https://stackoverflow.com/questions/44988841/force-tableswitch-instead-of-lookupswitch), because the default
-XX:MinJumpTableSizeis 10 and beyond it, the JIT would produce a jump table, instead of having a sort-of binary search among cases, just using a cascade ofif.This could be alleviated in different ways, like grouping the mostly expected handler(s) type in a main switch and have another "slower path" switch for known but still usually not present handler types.