-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Create procedure doc for use case "Deploy to Openshift in a single step" #45643
base: main
Are you sure you want to change the base?
Conversation
ef47119
to
15a6320
Compare
7484692
to
99e9386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend enclosing the admonitions in ====
blocks, although I wouldn’t expect that to directly cause the error you’re encountering. If that doesn’t resolve the issue, I’d suggest commenting out the include I mentioned earlier to see if it has any impact.
This is outside my area of expertise, but I also wonder if your local system might no longer meet the minimum requirements for the new Quarkus version. It’s possible that more recent versions of dependencies are now required.
Perhaps @MichalMaler and @jmartisk have some insights?
[TIP] | ||
If you want to test your application immediately, set the `quarkus.openshift.route.expose` config property to `true` to expose the service automatically. | ||
For example, add `-Dquarkus.openshift.route.expose=true` to the command above. | ||
For more information, see xref:deploying-to-openshift.adoc#exposing_routes[Exposing routes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TIP] | |
If you want to test your application immediately, set the `quarkus.openshift.route.expose` config property to `true` to expose the service automatically. | |
For example, add `-Dquarkus.openshift.route.expose=true` to the command above. | |
For more information, see xref:deploying-to-openshift.adoc#exposing_routes[Exposing routes]. | |
[TIP] | |
==== | |
If you want to test your application immediately, set the `quarkus.openshift.route.expose` config property to `true` to expose the service automatically. | |
For example, add `-Dquarkus.openshift.route.expose=true` to the command above. | |
For more information, see xref:deploying-to-openshift.adoc#exposing_routes[Exposing routes]. | |
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thank you.
[IMPORTANT] | ||
As of OpenShift 4.14, the `DeploymentConfig` object is deprecated. | ||
For more information, see https://access.redhat.com/articles/7041372. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[IMPORTANT] | |
As of OpenShift 4.14, the `DeploymentConfig` object is deprecated. | |
For more information, see https://access.redhat.com/articles/7041372. | |
[IMPORTANT] | |
==== | |
As of OpenShift 4.14, the `DeploymentConfig` object is deprecated. | |
For more information, see https://access.redhat.com/articles/7041372. | |
==== |
99e9386
to
b3bee1e
Compare
🎊 PR Preview 2952e62 has been successfully built and deployed to https://quarkus-pr-main-45643-preview.surge.sh/version/main/guides/
|
Hi @iocanel, |
b3bee1e
to
edc9748
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
- I don't see a reason for refering to Service Binding here.
- Move notes about DeploymentConfig -> Deployment down (or remove completely).
- Show the command earlier on thee doc.
- Provide alternatives for maven / gradle when the CLI is not available
For more information, see xref:deploying-to-openshift.adoc#exposing_routes[Exposing routes]. | ||
==== | ||
|
||
[[re-deploy-with-service-binding]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should have any reference to service binding in the deploy in a single step
doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed paragraph. Note, this service binding reference was in the existing upstream guide. Should it be added elsewhere in one of the other procedures/guides?
:topics: devops,kubernetes,openshift,cloud,deployment | ||
:extensions: io.quarkus:quarkus-openshift | ||
|
||
As an application developer, you build and deploy your {project-name} applications to {openshift} by using a single command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what command?
Signed-off-by: shjones <[email protected]>
Signed-off-by: shjones <[email protected]>
Signed-off-by: shjones <[email protected]>
Signed-off-by: shjones <[email protected]>
edc9748
to
cc0a2c7
Compare
Status for workflow
|
This PR aims to draft a procedure for the following use case
Reference: Deploying on OpenShift