-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle REST field injection #45950
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the inherited fields don't make the class auto-@RequestScoped
.
...c/main/java/io/quarkus/resteasy/reactive/server/deployment/QuarkusServerEndpointIndexer.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/quarkus/resteasy/reactive/server/deployment/QuarkusServerEndpointIndexer.java
Outdated
Show resolved
Hide resolved
...a/io/quarkus/resteasy/reactive/server/test/injection/HeaderFieldInSuperClassNoScopeTest.java
Outdated
Show resolved
Hide resolved
The point of the test is to show that the auto-conversion mechanism is best effort. In this specific case we could do extra work to figure out that field injection is needed, but it will never be as complete as the EndpointIndexer and thus we need to be able to fail the build when the best effort conversion was not enough |
This is a breaking change, but I think it's backport is warranted @gsmet @cescoffier |
OK, we can always improve later |
I actually might have to do it now because some of the TCK tests are failing... |
PR updated. We should actually fail now in far fewer cases |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is done by converting the Resource class to @RequestScoped when possible and failing the build when it's not
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
This is done by converting the Resource class to
@RequestScoped
when possible and failing the build when it's not