Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle REST field injection #45950

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Correctly handle REST field injection #45950

merged 1 commit into from
Jan 30, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 29, 2025

This is done by converting the Resource class to
@RequestScoped when possible and failing the build when it's not

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes release/breaking-change and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 29, 2025
@geoand geoand requested a review from FroMage January 29, 2025 13:29

This comment has been minimized.

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the inherited fields don't make the class auto-@RequestScoped.

@geoand
Copy link
Contributor Author

geoand commented Jan 29, 2025

I'm not sure why the inherited fields don't make the class auto-@RequestScoped.

The point of the test is to show that the auto-conversion mechanism is best effort. In this specific case we could do extra work to figure out that field injection is needed, but it will never be as complete as the EndpointIndexer and thus we need to be able to fail the build when the best effort conversion was not enough

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Jan 29, 2025
@geoand
Copy link
Contributor Author

geoand commented Jan 29, 2025

This is a breaking change, but I think it's backport is warranted @gsmet @cescoffier

@FroMage
Copy link
Member

FroMage commented Jan 29, 2025

The point of the test is to show that the auto-conversion mechanism is best effort. In this specific case we could do extra work to figure out that field injection is needed, but it will never be as complete as the EndpointIndexer and thus we need to be able to fail the build when the best effort conversion was not enough

OK, we can always improve later

@geoand
Copy link
Contributor Author

geoand commented Jan 29, 2025

I actually might have to do it now because some of the TCK tests are failing...

@geoand
Copy link
Contributor Author

geoand commented Jan 29, 2025

PR updated. We should actually fail now in far fewer cases

This comment has been minimized.

This comment has been minimized.

This is done by converting the Resource class to
@RequestScoped when possible and failing the build
when it's not

This comment has been minimized.

Copy link

quarkus-bot bot commented Jan 30, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9eb48b4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 02ff9ed into quarkusio:main Jan 30, 2025
48 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 30, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 30, 2025
@geoand geoand deleted the #45789 branch January 30, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[resteasy-reactive] [3.8.6] Header not reset between request
2 participants