Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven: add "copySurefireVariables" config to the "dev" and "test" goals #45951

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 29, 2025

Disabled by default. If enabled, the <environmentVariables> and <systemPropertyVariables> from the Maven Surefire plugin configuration are copied to the Quarkus Maven plugin, to prevent duplication.

Fixes #24249

@Ladicek Ladicek requested a review from aloubyansky January 29, 2025 13:43
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jan 29, 2025

This comment has been minimized.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ladicek !

Disabled by default. If enabled, the `<environmentVariables>` and
`<systemPropertyVariables>` from the Maven Surefire plugin configuration
are copied to the Quarkus Maven plugin, to prevent duplication.
@Ladicek Ladicek force-pushed the maven-copy-surefire-variables branch from 0c381c6 to 5f03a92 Compare January 30, 2025 08:21
Copy link

quarkus-bot bot commented Jan 30, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5f03a92.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

📦 integration-tests/reactive-messaging-context-propagation

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagation - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

@Ladicek Ladicek merged commit 0fa6c57 into quarkusio:main Jan 30, 2025
51 checks passed
@Ladicek Ladicek deleted the maven-copy-surefire-variables branch January 30, 2025 10:52
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 30, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse maven-surefire-plugin environmentVariables and systemPropertyVariables for continuous testing
2 participants