Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content about running the application in the JWT guide #45956

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sberyozkin
Copy link
Member

It aligns it with how running the application in JVM and native modes is presented the OIDC bearer token tutorial, stating from https://quarkus.io/guides/security-oidc-bearer-token-authentication-tutorial#run-the-application-in-jvm-mode

CC @mocenas

Copy link

github-actions bot commented Jan 29, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@sberyozkin
Copy link
Member Author

@rolfedh @mocenas I've also tried to optimize curl command fragments, as @mocenas pointed out the copy and paste gets too much content otherwise. I've removed examples where a complete JWT is used as those tokens must have expired long time ago

Copy link

quarkus-bot bot commented Jan 29, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 32d5852.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sberyozkin
Copy link
Member Author

Thanks @rolfedh I've looked at the generated docs and it looks better IMHO, so let's merge it for @mocenas to have a look

@sberyozkin sberyozkin requested a review from gastaldi January 29, 2025 22:30
@sberyozkin
Copy link
Member Author

George, please approve as it looks ok to you, should be good to go with Rolfe's approval

@gastaldi gastaldi merged commit 22d6c64 into quarkusio:main Jan 29, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants