Allow for asynchronousness in span processing in test #45963
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of this, @brunobat? One of my goals with https://github.com/orgs/quarkusio/projects/30 is that it shouldn't be necessary to change any tests, and this changes a test. But I think I have a plausible explanation for why my changes expose a problem that's actually a test issue? |
This comment has been minimized.
This comment has been minimized.
holly-cummins
changed the title
brunobat
requested changes
Jan 30, 2025
...e/src/test/java/io/quarkus/it/opentelemetry/reactive/OpenTelemetryWithSpanAtStartupTest.java
Show resolved
Hide resolved
holly-cummins
force-pushed
the
allow-asynchronous-otel
branch
from
b64220f to
2c7889e
Compare
Status for workflow
|
brunobat
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45955