Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working groups page and layout #2046

Closed
wants to merge 1 commit into from
Closed

Add working groups page and layout #2046

wants to merge 1 commit into from

Conversation

cescoffier
Copy link
Member

  • Provide the script that generate the wg.yaml
  • Create a workflow that update the working group yaml periodically
  • Add the wg page and layout
  • A bit of CSS to make the page looks ok

@cescoffier
Copy link
Member Author

@gsmet Can you have a look when you are back?

@cescoffier cescoffier requested a review from gsmet July 17, 2024 08:52
@gsmet gsmet marked this pull request as ready for review August 10, 2024 11:32
gsmet
gsmet approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but nothing blocking:

  • we need a dark theme for the cards (and probably more love from @insectengine)
  • you're talking about contacting a point of contact but there's none
  • not completely sure about having wg as the url. I would have gone with working-groups for better SEO. You will have a link or a bookmark.
  • we need to include it in the nav somewhere (probably something to discuss with @insectengine )

In any case, nothing blocking, I let you address what you think makes sense and merge.

@cescoffier @gsmet
Add working groups page and layout
239f5c9 
- Provide the script that generate the wg.yaml
- Create a workflow that update the working group yaml periodically
- Add the wg page and layout
- A bit of CSS to make the page looks ok
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@insectengine
Copy link
Collaborator

@gsmet - I'll look at the styling and light/darkmode

@insectengine
Copy link
Collaborator

workinggroups_styling_dark
workinggroups_styling_light
workinggroups_nav

  1. Took some liberties with the intro text.
  2. Used styling from our existing card styling and removed the grey backgrounds on the header/footer of the cards.
  3. Changed from 2 columns to 3.
  4. Replaced the outbound board buttons with links as "buttons do things, links go places" (even though we're not 100% compliant elsewhere). The buttons also broke the mobile view.
  5. Revised the date format in yaml to sync with other pages (newsletter, insights, etc)
  6. Made light/dark mode compliant.
  7. Added to "Community" section of site as this is shows users how to contribute/participate.

@insectengine
Copy link
Collaborator

insectengine commented Aug 14, 2024 •
edited
Loading

Submitted a PR with my changes:
#2080

@insectengine insectengine mentioned this pull request Aug 14, 2024
Merged
@gsmet
Copy link
Member

gsmet commented Aug 14, 2024

I will close this one so that we iterate on yours.

@gsmet gsmet closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cescoffier @insectengine @gsmet