Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give preview jobs higher permissions so that preview comments can work #2061

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Jul 31, 2024

@maxandersen spotted that his recent blog post didn't get a preview. On investigation, it did get a preview, but it didn't get a comment on the PR with the preview link. On further investigation, previews have been failing for 3 weeks.

Based on the timing and content, I think the problem must have been caused by #2042. It contains the fatal equivalent of // this should never happen, this should be enough to ... :)

    permissions:
      actions: read
      # this should be enough to maintain comments as commenting on pull requests is done through an issues API
      issues: write
      pull-requests: read

The GitHub workflow changes can only be tested by YOLO-ing them in and then hoping, so regressions are super-easily done. I'm hoping this change fixes it, but, you know ... it can only be tested by YOLO-ing it in.

.github/workflows/preview.yml Show resolved Hide resolved
@gsmet gsmet merged commit 7eec902 into quarkusio:main Aug 1, 2024
1 check passed
Copy link

github-actions bot commented Aug 1, 2024

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants