build: small improvements and related changes #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
reviewed
Aug 3, 2023
Makefile
Outdated
| go mod vendor | ||
|
|
||
| comma := , | ||
| volflags:= rw$(if $(findstring podman,$(docker)),$(comma)Z,) | ||
| build-vols := --volume "$$(go env GOMODCACHE):/go/pkg/mod:$(volflags)"\ |
There was a problem hiding this comment.
I guess this is podman build option only and not docker build
There was a problem hiding this comment.
The selinux labeling? I think so yeah.
Edit: Oh, yeah I see what you mean.
hdonnay
force-pushed
the
hack/docker-build
branch
from
da41c21
to
859a6de
Compare
This invocation is equivalent and should be slightly faster by letting all the commands link in parallel. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
hack/docker-build
branch
from
859a6de
to
7cc2107
Compare
crozzy
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes: