-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cicd: fix docker test #2032
Merged
Merged
cicd: fix docker test #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
bug/nightly-ci
branch
4 times, most recently
from
April 10, 2024 22:42
d02c8ec
to
8020e1e
Compare
Having a script in a shell argument in a script is probably not ideal. This now writes out a script and mounts it into the container to run, which is much easier to see what's run in which context and removes some annoying quoting. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Waiting for quay/claircore#1314 to be merged, then I'll double check that these changes make everything green again. |
crozzy
previously approved these changes
Apr 11, 2024
Now waiting on quay/claircore#1319 because there was another, different bug. |
I guess this didn't have any changes in this repo, but please push the button again |
crozzy
approved these changes
Apr 12, 2024
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions is the worst CI except for every other CI service.