build: fixing references in Dockerfile (PROJQUAY-8087) #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaton85
changed the title
hdonnay
requested changes
Oct 16, 2024
There was a problem hiding this comment.
This changes the Dockerfile to execute a bash command (with broken escaping I think) instead of a script. That is, it executes sh -c 'bash <<. ...' instead of sh -c '...'. In the latter, the heredoc is Dockerfile syntax whereas in the former it's shell syntax.
I think any changes should only be made if there's a problem running this via buildkit, which is the only upstream-supported container builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables within the heredoc need to be escaped in order to be assigned correctly.
Signed-off-by: bcaton [email protected]