-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Proposal for QuickVega #9
Open
davibarreira
wants to merge
46
commits into
queryverse:master
Choose a base branch
from
davibarreira:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relying on DataFrames.jl.
…fy Char as nominal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very substantial amount of code. Here is an overview of what is coded:
Each one has multiple dispatch, enabling the user to pass the actual vectors, or dataframes, or matrices.
The code for each plot is straightforward.
The other main part of the code is the file updateSpec.jl. In this file, there is the function
updatePlot!
, which receives a VLSpecand modifies according to the argument supplied. This function is responsible for modifying the plots accordingly to the
kwargs
sent by the users in the original plots. The function is just a long list of conditionals, where each conditional identifies
the argument sent by the user and modifies the plot.
I've also implemented a way for the user to set default settings for all plots, which can be done by modifying the QuickVega.defaultParameters dictionary. Also, I've created a "dark theme", which can be used by calling the function
setTheme!(:dark)
.Inside the folder "sandbox" there is a jupyter notebook file with examples for all the code implemented.
Oh, I've also created a logo, listed some possible "desirable features" and put all in the Readme.