tests

test/common/data/instrument_test.go

@@ -3,7 +3,6 @@ package data_test
 import (
 	"testing"
 	"time"
-	goErrors "errors"
 
 	"xoney/common/data"
 	"xoney/errors"
@@ -34,14 +33,17 @@ func TestSymbolExchange(t *testing.T) {
 }
 
 func TestTimeFrameIncorrect(t *testing.T) {
-	duration := time.Duration(-1234)
+	duration := time.Duration(-time.Hour)
 	_, err := data.NewTimeFrame(duration, "incorrect tf")
 
-	expected := errors.NewIncorrectDurationError(time.Duration(-1234))
+	expected := "invalid duration: -1h0m0s."
 
-	if !goErrors.Is(err, expected) {
+	if err.Error() != expected {
 		t.Errorf("Expected IncorrectDurationError, got: %s", err.Error())
 	}
+	if _, ok := err.(errors.IncorrectDurationError); !ok {
+		t.Errorf("Expected IncorrectDurationError, got: %v", err)
+	}
 }
 
 func Daily() data.TimeFrame {

test/common/portfolio_test.go

@@ -2,6 +2,7 @@ package common_test
 
 import (
 	"testing"
+	"strings"
 
 	"xoney/common"
 	"xoney/common/data"
@@ -80,7 +81,18 @@ func TestPortfolioTotal(t *testing.T) {
 	if err.Error() != expected.Error() {
 		t.Errorf("Expected MissingCurrencyError, got: %v", err)
 	}
+	if strings.Contains(err.Error(), ", ") {
+		t.Errorf("Unexpected ', ' in error, got: %v", err)
+	}
+
+	// Without both currencies
+	delete(prices, eth)
 
+	_, err = portfolio.Total(prices)
+
+	if !strings.Contains(err.Error(), ", ") {
+		t.Errorf("Expected ', ' in error, got: %v", err)
+	}
 }
 
 func TestPortfolioBalance(t *testing.T) {

test/exchange/connetor_test.go

@@ -240,6 +240,9 @@ func TestMarginSimulator_CancelOrder_NonExistingOrder(t *testing.T) {
 	if !goErrors.Is(err, expectedError) {
 		t.Errorf("Expected NoLimitOrderError, got: %v", err)
 	}
+	if err.Error() != "there is no such limit order with ID: 123." {
+		t.Errorf("Incorrect text of error: %v", err)
+	}
 }
 
 func TestMarginSimulator_CancelOrder_ExistingOrder(t *testing.T) {