Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retrieve one batch of messages at a time when responding to a large resend request #643

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philipwhiuk
Copy link
Contributor

Fixes #639

@chrjohn
Copy link
Member

chrjohn commented Jul 5, 2024

@philipwhiuk do you happen to have the time to create a unit test for this? So we can ensure that normal resend processing works as expected? Probably a test where we resend more than 1000 messages and check that every message is resent. Something along that lines?
Thank you :)
Edit: call me paranoid but I'm always cautious when introducing new loops with seqnum+1... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During a resend-request the request for messages from storage allows for unbounded memory usage
2 participants