Account for probe size limits before coalescing #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a datagram is a loss probe, it must be at most 1200 bytes. This limit must be accounted for before we judge whether there's enough space to coalesce another packet.
Ralith
force-pushed
the
fix-coalescing-with-probe
branch
from
0b61f8c to
1a73783
Compare
Ralith
changed the title
Ralith
changed the title
This was referenced Nov 16, 2024
djc
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another bug found in #2020.
When a datagram is a loss probe, it must be at most 1200 bytes. This limit must be accounted for before we judge whether there's enough space to coalesce another packet.