Upgrade to rand 0.9 #2144
Merged
Upgrade to rand 0.9 #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
gretchenfrage
requested changes
Jan 28, 2025
There was a problem hiding this comment.
WASM CI error. Per message, it looks like we have to pass a new RUSTFLAGS env var in WASM CI?
Note @matheus23 's suggested patch |
Ralith
approved these changes
Jan 30, 2025
gretchenfrage
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Diff itself looks good! But interested in the 2 remaining CI failures. I'm manually re-running the Solaris test because it seems like it was just flaky. But there's also this audit CI failure relating to libfuzzer licensing:
error[rejected]: failed to satisfy license requirements
┌─ registry+https://github.com/rust-lang/crates.io-index#[email protected]:4:36
│
4 │ license = "(MIT OR Apache-2.0) AND NCSA"
│ ────────────────────────━━━━
│ │ │
│ │ rejected: license is not explicitly allowed
│ license expression retrieved via Cargo.toml `license`
│
├ NCSA - University of Illinois/NCSA Open Source License:
├ - OSI approved
├ - FSF Free/Libre
├ libfuzzer-sys v0.4.9
└── fuzz v0.1.0
It's not entirely clear to me why that failure would be new, though.
|
Also probably not very important since it's just a dev-dep (right?) |
|
Addressed the audit failure in #2148. |
gretchenfrage
approved these changes
Jan 30, 2025
gretchenfrage
force-pushed
the
rand-0.9
branch
from
7de2b1e to
bf02aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, getrandom 0.3.