Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make end armor trimmable / add end trim materials #440

Open
wants to merge 7 commits into
base: 1.21
Choose a base branch
from

Conversation

OpenBagTwo
Copy link

Coulda sworn there was an issue asking for this, but anyway, my 9yo has been begging for it 😆

A few notes:

  • Crystalite is too busy for trims to appear or really make sense
  • Armored Elytra is trimmable, and I had to change the item texture to make the trim overlay not look like garbage (the alternative would be to create a custom trim overlay, a la this example)
  • No datagen (I just did it within an interactive Python session), because:
    • I'm still not 💯 on how to run datagen for BE
    • I'm not sure how to get at the Thallasium and Terminite armor pieces within the mod, given the current structure
    • I think work would need to be put in upstream (into WorldWeaver) to handle generating the myriad {material}_{piece}_{trim}_trim.json files

@OpenBagTwo OpenBagTwo changed the title Make end armor trimmable Make end armor trimmable / add end trim materials Jul 20, 2024
@OpenBagTwo
Copy link
Author

I also added amber gems and crystal shards as trim materials.
thallasium armor with end trims
netherite armor with end trims

Again: did the datagen in Python, which is why they're not in the "generated" folder—if you implement a Wover model data provider, you'll obviously want to move everything there.

@OpenBagTwo OpenBagTwo force-pushed the trims branch 2 times, most recently from cfe5c44 to 3557606 Compare July 30, 2024 23:14
@OpenBagTwo
Copy link
Author

With 433b82b, this PR now additionally updates the language file entries for the music discs. Alternatively, @frankbauer, you could update the datagen to simply specify the old locations for the jukebox song names. That is, there's nothing to say that in the translate key in jukebox_song/endseeker.json:

"translate": "jukebox_song.betterend.endseeker"

couldn't still point to: item.betterend.music_disc_endseeker.desc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant