Fix Arabic Number Bug and Improve Notes Sharing #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yismailuofa
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 40.92% 39.56% -1.37%
==========================================
Files 525 526 +1
Lines 20880 19505 -1375
==========================================
- Hits 8546 7717 -829
+ Misses 12334 11788 -546 ☔ View full report in Codecov by Sentry. |
mohamede1945
approved these changes
Sep 19, 2024
|
Jazak Allah Khyrn Youssef for fixing them. I tried to repro #666 but I couldn't. |
|
@mohamede1945 For reference, I’m on ios18. Maybe #666 is as well? |
|
Oh, I see. I'm still on ios 17. Also, I've sent a new version for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Tafseer view and notes view has English numbers for Ayat despite app language being Arabic #666,
I think maybe Apple changed the locale keys in the new update ? The docs say it uses BCP-47. So updated the string to use this.
Refactors the sharing abit to make it more consistent, since sometimes English and Arabic would be on the same line, now we add newlines properly I think.
Updates the ayah sharing to use the same logic as copy. Before copy would have newlines and sharing didn't but now they should both have it.