Skip to content

Commit

Permalink
Fix: reoslves undefined and patch requests issue (#2235)
Browse files Browse the repository at this point in the history
* fix: add patch in signature gen to use body

* fix: undifend issue in selected translation
  • Loading branch information
mohsinayoob authored and osamasayed committed Nov 18, 2024
1 parent 95de294 commit 684670d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
12 changes: 8 additions & 4 deletions src/components/MediaMaker/Settings/TranslationSectionSetting.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,23 @@ const TranslationSettingsSection: React.FC<Props> = ({ onSettingsUpdate, transla
if (!data) {
return null;
}
const availableTranslations = translations.filter((selectedId) =>
data.translations.some((translation) => translation.id === selectedId),
);

const firstSelectedTranslation = data.translations.find(
(translation) => translation.id === translations[0],
(translation) => translation.id === availableTranslations[0],
);

let selectedValueString = t('settings.no-translation-selected');
if (translations.length === 1) selectedValueString = firstSelectedTranslation?.name;
if (translations.length === 2) {
if (availableTranslations.length === 1) selectedValueString = firstSelectedTranslation?.name;
if (availableTranslations.length === 2) {
selectedValueString = t('settings.value-and-other', {
value: firstSelectedTranslation?.name,
othersCount: localizedSelectedTranslations,
});
}
if (translations.length > 2) {
if (availableTranslations.length > 2) {
selectedValueString = t('settings.value-and-others', {
value: firstSelectedTranslation?.name,
othersCount: localizedSelectedTranslations,
Expand Down
3 changes: 2 additions & 1 deletion src/utils/auth/signature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ const generateSignature = (
let params = {};

try {
if (req.method === 'POST' || req.method === 'PUT') {
const methodsWithBody = ['POST', 'PUT', 'PATCH'];
if (methodsWithBody.includes(req.method)) {
params = req.body;
}
} catch (err) {
Expand Down

0 comments on commit 684670d

Please sign in to comment.