-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polish language to the website #2120
Open
BilalHassona
wants to merge
11
commits into
quran:master
Choose a base branch
from
Bilal-Hassona-1:polish-language
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files. App compiles.
…ters display a bit.
@BilalHassona is attempting to deploy a commit to the Quran Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is excellent. We need this polish translation! |
Saidamir-Sh
reviewed
May 22, 2024
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assalamu alaykum, this PR adds Polish language to the website. I am native Polish speaker and fluent in English (Level C1/C2). The PR is ready to be merged and should work without any issues with few small caveats:
My methodology was: translate as closely as possible to the originial (English) text – including punctuation. If not possible I would change the text as much as needed so that it made sens in Polish – and preserve the intended meaning. I see that special characters in French don't look great as well, so please let me know if I should search for a better font (and potentially add it to the project). For now I just improved Polish special characters with the existing fonts.
I added the Polish language above "Português" on the dropdown as per @Saidamir-Sh request (image 2).
Further contribution (not related to this PR)
I would love to contribute more (and I don't want any financial compensation) namely:
Please let me know if those contributions are needed and if they will accepted and if yes, then please help me find the needed answers. You can respond here or via Discord: my username: "0_.b.h._0" or any other way – I will adjust to you.
Test Plan
Run the App locally and change the translation (top-right corner with "globe" icon) to "Polski" – check if everything works and looks correctly.
Screenshots