Hotfixes for issues 87, 97, 98 #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te contours with warning
|
Working out a couple bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple commits that address a few small open issues:
Fixing degenerate contours - issue 87
Contours with fewer than three points threw an error from opencv. Fix detects, fixes the issue making an assumption, and continues with warning.
Checking for nonuniform slice thickness - issue 97
Hotfix: Checks for non-uniform slice thickness and raises an Exception if detected. Exception type should probably be made more specific.
Option for support for multiple acquisitions - issue 98
Adds a parameter to get_roi_mask_by_name passed through to create_series_mask_from_contour_sequence that adds functionality for images with multiple acquisitions, optionally splitting the output mask along an additional axis at the end.