Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Time Evolution Tutorials #31

Merged
merged 29 commits into from
Aug 19, 2022

Conversation

christian512
Copy link
Collaborator

This adds more tutorials on steady state and stochastic solver.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up doing a reasonably thorough review because I got interested in the optomechanical example after this morning's discussion. :)

tutorials-v4/optomechanical-steadystate.md Outdated Show resolved Hide resolved
tutorials-v4/optomechanical-steadystate.md Outdated Show resolved Hide resolved
tutorials-v4/optomechanical-steadystate.md Outdated Show resolved Hide resolved
tutorials-v4/homodyned-Jaynes-Cummings-emission.md Outdated Show resolved Hide resolved
tutorials-v4/measures-trajectories-cats-kerr.md Outdated Show resolved Hide resolved
tutorials-v4/measures-trajectories-cats-kerr.md Outdated Show resolved Hide resolved
tutorials-v4/measures-trajectories-cats-kerr.md Outdated Show resolved Hide resolved
tutorials-v4/measures-trajectories-cats-kerr.md Outdated Show resolved Hide resolved
tutorials-v4/measures-trajectories-cats-kerr.md Outdated Show resolved Hide resolved
@christian512
Copy link
Collaborator Author

Thanks for the review! :) I updated the tutorial accordingly.

I also reduced the number of solvers used in optomechanical-steadystate to have a more reasonable runtime.

@christian512
Copy link
Collaborator Author

I have moved the tutorials into the time-evolution folder, which is required later on for creating the index page.I also updated the titles of the notebooks to match the titles at the tutorials website.

@christian512 christian512 mentioned this pull request Aug 16, 2022
# use QuTiP's builtin parallelized for loop, parfor
results = parfor(brme_step, itertools.product(wd_list, Om_list))
# use QuTiP's builtin parallelized for loop: parallel_map
results = parallel_map(brme_step, list(itertools.product(wd_list, Om_list)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this example should be using the class interface instead of the function call in v5.
The class interface is to be used when computing the same system with different parameters, which is what is done here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @Ericgig! I changed from using brmesolve to BRSolver in the last commit. BRSolver currently requires that the spectra for the a_ops are given as coefficient. Hence, I can not pass a string spectrum.

I think it would be great if BRSolver also accepts other types of spectra.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good. Some questions:

  • Are notebooks 15, 16 and 17 in a separate PR?
  • It would be nice to automatically trim empty python cells at the end of the notebooks, or at least to warn about them in the test runs, but maybe just create an issue for that?

@christian512
Copy link
Collaborator Author

Thanks for the review, @hodgestar!
The notebooks 15, 16, 17 are the Stochastic Solver notebooks in #30.

I opened an issue to create a test for empty code cells in #38.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some images here are still in a top-level images folder, but once they're moved closer to their notebooks I'm happy for this to be merged.

@christian512 christian512 mentioned this pull request Aug 19, 2022
@christian512 christian512 merged commit 44cc419 into qutip:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants