Skip to content

Commit

Permalink
Pin sympy to 1.13.1 (pytorch#133235)
Browse files Browse the repository at this point in the history
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac

https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100

Hopefully these are the places it needs to get pinned
Pull Request resolved: pytorch#133235
Approved by: https://github.com/atalman, https://github.com/ZainRizvi
  • Loading branch information
clee2000 authored and pytorchmergebot committed Aug 12, 2024
1 parent 36c4ed8 commit 4f0d5f6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .ci/docker/requirements-ci.txt
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,9 @@ lxml==5.0.0
# Python-3.9 binaries

PyGithub==2.3.0

sympy==1.12.1 ; python_version == "3.8"
sympy==1.13.1 ; python_version >= "3.9"
#Description: Required by coremltools, also pinned in .github/requirements/pip-requirements-macOS.txt
#Pinned versions:
#test that import:
2 changes: 1 addition & 1 deletion .github/requirements/pip-requirements-macOS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pytest-rerunfailures==10.3
pytest-flakefinder==1.1.0
scipy==1.10.1
sympy==1.12.1 ; python_version == "3.8"
sympy>=1.13.0 ; python_version >= "3.9"
sympy==1.13.1 ; python_version >= "3.9"
unittest-xml-reporting<=3.2.0,>=2.0.0
xdoctest==1.1.0
filelock==3.6.0
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ setuptools
types-dataclasses
typing-extensions>=4.8.0
sympy==1.12.1 ; python_version == "3.8"
sympy>=1.13.0 ; python_version >= "3.9"
sympy==1.13.1 ; python_version >= "3.9"
filelock
networkx
jinja2
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ def main():
"filelock",
"typing-extensions>=4.8.0",
'sympy==1.12.1 ; python_version == "3.8"',
'sympy>=1.13.0 ; python_version >= "3.9"',
'sympy==1.13.1 ; python_version >= "3.9"',
"networkx",
"jinja2",
"fsspec",
Expand Down

0 comments on commit 4f0d5f6

Please sign in to comment.