Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugzilla#18710] Turn on warnPartialMatch* by default #165

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Apr 22, 2024

@llrs
Copy link
Member

llrs commented Apr 24, 2024

Wow, this many and only in tests, not even inside the R code...
Note that there are some changes in white spaces (and no other change), for example tests/arith-true.R Line 186.

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Apr 26, 2024

Wow, this many and only in tests, not even inside the R code...

That's expected IMO, codetools::checkUsage(suppressPartialMatchArgs=FALSE) is part of R CMD check --> partial match usage in package code is much likelier to be detected (since issues with $ / attr() are much rarer to begin with):

suppressPartialMatchArgs = FALSE,

@MichaelChirico MichaelChirico changed the title turn on warnPartialMatch* by default [Bugzilla#18710]turn on warnPartialMatch* by default Apr 26, 2024
@MichaelChirico MichaelChirico changed the title [Bugzilla#18710]turn on warnPartialMatch* by default [Bugzilla#18710] Turn on warnPartialMatch* by default Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants