Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review, add and improve unit tests #42

Closed
10 tasks done
GegznaV opened this issue Jul 27, 2021 · 3 comments · Fixed by #57, #49, #47 or #81
Closed
10 tasks done

Review, add and improve unit tests #42

GegznaV opened this issue Jul 27, 2021 · 3 comments · Fixed by #57, #49, #47 or #81

Comments

@GegznaV
Copy link
Member

GegznaV commented Jul 27, 2021

Codecov

Review, fix, add and improve unit tests for these functions and their helpers:

  • count_lines
  • read_asc_Andor
  • read_asc_PerkinElmer
  • read_txt_Shimadzu
@GegznaV
Copy link
Member Author

GegznaV commented Jul 30, 2021

In unit tests, make sure to check that the values in each hyperSpec slot (@data (non-spectra), @data$spc (spectra), @wavelength, and @label) are checked and that column names of @data and @data$spc are correct. This will let us detect discrepancies easier than just by using hash code.

@GegznaV
Copy link
Member Author

GegznaV commented Jul 30, 2021

@sangttruong, I assign this to you, as hySpc.read.txt is mentioned in your GSoC proposal. OK?

Create a separate branch for each file so that it was easier to review.

@GegznaV
Copy link
Member Author

GegznaV commented Aug 10, 2021

This is not closed yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment