-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/42-read-txt-horiba-xy #49
Conversation
Why are there 150+ files changed in this PR when only 1 file should be? (Most probably the files currently are in the wrong place to be reached by unit tests). |
@sangttruong, Did you answer or solve @cbeleites comments like the one on the print screen above? You can find them under the "Files changes" section (this applies to all pull requests). In case of doubt about what to do, please, answer to the comments directly on GitHub and not on Slack so that every mentor could contribute to the discussion and could know what is the status of the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sangttruong, add unit tests defined in template #55 as additional tests to the current ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, all comments and requested changes have been made; if something has been missed a new issue can be opened. OK to merge.
Add unittest for read_txt_Horiba_xy()
Resolve #42