Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/42-read-txt-horiba-xy #49

Merged
merged 14 commits into from
Aug 10, 2021
Merged

Conversation

sangttruong
Copy link

@sangttruong sangttruong commented Aug 1, 2021

Add unittest for read_txt_Horiba_xy()
Resolve #42

@GegznaV
Copy link
Member

GegznaV commented Aug 1, 2021

Why are there 150+ files changed in this PR when only 1 file should be? (Most probably the files currently are in the wrong place to be reached by unit tests).
I also noticed that the same trend of 150+ changed files is in the last few PRs (which makes it more difficult to review). @sangttruong, are the same files moved again and again in separate PRs? Or are these different files?

R/read_txt_Horiba.R Outdated Show resolved Hide resolved
@GegznaV GegznaV mentioned this pull request Aug 2, 2021
R/read_txt_Horiba.R Outdated Show resolved Hide resolved
R/read_txt_Horiba.R Outdated Show resolved Hide resolved
R/read_txt_Horiba.R Outdated Show resolved Hide resolved
R/read_txt_Horiba.R Show resolved Hide resolved
@GegznaV
Copy link
Member

GegznaV commented Aug 9, 2021

image

@sangttruong, Did you answer or solve @cbeleites comments like the one on the print screen above?

You can find them under the "Files changes" section (this applies to all pull requests).

image

In case of doubt about what to do, please, answer to the comments directly on GitHub and not on Slack so that every mentor could contribute to the discussion and could know what is the status of the issue.

Copy link
Member

@GegznaV GegznaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangttruong, add unit tests defined in template #55 as additional tests to the current ones.

R/read_txt_Horiba.R Outdated Show resolved Hide resolved
R/read_txt_Horiba.R Outdated Show resolved Hide resolved
@GegznaV GegznaV marked this pull request as draft August 9, 2021 12:19
@sangttruong sangttruong marked this pull request as ready for review August 10, 2021 02:11
Copy link
Collaborator

@bryanhanson bryanhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, all comments and requested changes have been made; if something has been missed a new issue can be opened. OK to merge.

@sangttruong sangttruong merged commit 3bcc3a2 into develop Aug 10, 2021
@sangttruong sangttruong deleted the features/42-read-txt-Horiba-xy branch August 10, 2021 02:35
@GegznaV GegznaV mentioned this pull request Aug 10, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review, add and improve unit tests
4 participants