Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Preserve _parent Environment in Async Functions for R6 Methods #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions R/generator.R
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,15 @@ generator0 <- function(fn, type = "generator") {

`_parent` <- environment()

# Create the generator factory (returned by `generator()` and
# entered by `async()`)
# FIX: Inject the captured _parent into the function’s formals as a default argument.
# This ensures that the environment is stored in the generated function and survives
# any environment replacement (e.g. when used as an R6 method).
fmls[[".__coro_env_parent__"]] <- `_parent`

# Create the generator factory (returned by `generator()` and entered by `async()`)
factory <- new_function(fmls, quote({
# Evaluate here so the formals of the generator factory do not
# mask our variables
`_private` <- rlang::env(`_parent`)
# Evaluate here so the formals of the generator factory do not mask our variables
`_private` <- rlang::env(.__coro_env_parent__)
`_private`$generator_env <- base::environment()
`_private`$caller_env <- base::parent.frame()

Expand Down Expand Up @@ -280,7 +283,8 @@ generator0 <- function(fn, type = "generator") {
structure(instance, class = "coro_generator_instance")
}
})
}))
# added call to caller_env() to ensure that the generator_env is created in the correct environment
}), env = caller_env())

structure(factory, class = c(paste0("coro_", type), "function"))
}
Expand Down
Loading