Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish and elvish completions #185

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Add fish and elvish completions #185

merged 5 commits into from
Sep 15, 2023

Conversation

TymekDev
Copy link
Contributor

clap_complete already supports both fish and elvish shells. This pull request adds completions for both of these.

@gaborcsardi
Copy link
Member

Thanks, looks great! To include the completions in the tar.gz/deb/rpm packages, you need to copy them to build in the Makefile, see here and below:

rig/Makefile

Line 56 in 74bb252

mkdir -p build/share/zsh/site-functions

@TymekDev
Copy link
Contributor Author

Done!

@gaborcsardi
Copy link
Member

Great, thank you!

@gaborcsardi gaborcsardi merged commit f228ce0 into r-lib:main Sep 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants