Allow NULL in vec_detect_complete()
#1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And better detect `NULL` columns and df-cols in data frames
DavisVaughan
commented
Mar 7, 2024
| } | ||
|
|
||
| static inline | ||
| void col_detect_complete_switch(SEXP x, R_len_t size, int* p_out) { |
There was a problem hiding this comment.
It's a copy of vec_detect_complete_switch() with different branches for data frames and NULL
It mirrors how we do it in vec_detect_missing()
| vec_rank(NULL, incomplete = "na") | ||
| Condition | ||
| Error: | ||
| ! This type is not supported by `vec_order()`. |
There was a problem hiding this comment.
This used to throw the internal error seen in #1823
There was a problem hiding this comment.
Probably not worth it but would be nice if:
- Argument name was reported
- Argument value was revealed
- Error happened earlier and mentioned
vec_rank() - A
callandargargument would allow callers to take ownersip of the type checking
lionel-
approved these changes
Mar 11, 2024
| vec_rank(NULL, incomplete = "na") | ||
| Condition | ||
| Error: | ||
| ! This type is not supported by `vec_order()`. |
There was a problem hiding this comment.
Probably not worth it but would be nice if:
- Argument name was reported
- Argument value was revealed
- Error happened earlier and mentioned
vec_rank() - A
callandargargument would allow callers to take ownersip of the type checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1823
And better detect
NULLcolumns and df-cols in data frames